-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vm state bug and deletion bug #340
Merged
shyamradhakrishnan
merged 3 commits into
oracle:main
from
shyamradhakrishnan:fix_vm_state_bug_and_deletion_bug
Oct 30, 2023
Merged
Fix vm state bug and deletion bug #340
shyamradhakrishnan
merged 3 commits into
oracle:main
from
shyamradhakrishnan:fix_vm_state_bug_and_deletion_bug
Oct 30, 2023
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te, and use ID from instance during deletion
…te, and use ID from instance during deletion
e2e
|
unit test
|
joekr
previously approved these changes
Oct 20, 2023
…te, and use ID from instance during deletion
joekr
approved these changes
Oct 30, 2023
shyamradhakrishnan
added a commit
to shyamradhakrishnan/cluster-api-provider-oci
that referenced
this pull request
Oct 31, 2023
* Do not put machine in failed state if VM is in stopping or stopped state, and use ID from instance during deletion
shyamradhakrishnan
added a commit
to shyamradhakrishnan/cluster-api-provider-oci
that referenced
this pull request
Mar 22, 2024
* Do not put machine in failed state if VM is in stopping or stopped state, and use ID from instance during deletion
shyamradhakrishnan
added a commit
to shyamradhakrishnan/cluster-api-provider-oci
that referenced
this pull request
Mar 29, 2024
* Do not put machine in failed state if VM is in stopping or stopped state, and use ID from instance during deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix vm state bug and deletion bug
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #337 , #339